Re: struct exception_table_entry

From: Michal Simek
Date: Wed Apr 15 2009 - 02:22:19 EST


Arnd Bergmann wrote:
> On Thursday 09 April 2009, Michal Simek wrote:
>
>
>> I am doing some cleanup things in MB MMU kernel and I looked at
>> exception_table_entry structure.
>> Only alpha use different types among others. Some arch use only
>> different names and types int/long.
>> I think that this structure could be moved to any generic location ->
>> asm-generic/uaccess.h folder.
>>
>> I think that this structure types should be acceptable for every archs?
>>
>> #ifndef exception_table_entry
>> struct exception_table_entry {
>> unsigned long insn;
>> unsigned long fixup;
>> };
>> #endif
>>
>> What do you think?
>>
>
> Yes, sounds good to me. Have you tried using my generic version of
> uaccess.h on microblaze? It already contains a definition like this,
> though most of the header doesn't apply for MMU-based architectures.
>
I haven't had time to look at it but it is on my list.
> I suppose it can be improved a bit, but should do the basic job.
>
yes of course. That was just my idea. Use it only for MMU kernels +
#ifndef for structure
doesn't work I think.

Thanks,
Michal
> Arnd <><
>


--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/