Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()
From: David Howells
Date: Tue Apr 14 2009 - 14:00:47 EST
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> We should have the DECLARE_PER_CPU() #defines next to the DEFINE_PER_CPU
> ones, rather than somewhere else.
>
> So moving the logic to <asm-generic/percpu.h> is wrong - make it all be in
> <linux/percpu.h> so that they can be maintained together.
Agreed, it would be nice. However, x86 requires it to be declared in the
middle of asm/percpu.h (ie: in asm-generic/percpu.h). I'm trying to sort it
out, but it's like trying to juggle hyperdimensional spaghetti:-/ How much
header file overhaul do you wish to indulge in? And can I split some headers
into separate headers for declarations and inline functions?
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/