Re: [PATCH] tracing/lockdep: turn lock->name into an array

From: Ingo Molnar
Date: Mon Apr 13 2009 - 19:01:42 EST



* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> TP_STRUCT__entry(
> - __field(const char *, name)
> + __array(char, name, LOCK_NAME_SIZE)
> __field(unsigned long, wait_usec)
> __field(unsigned long, wait_nsec_rem)
> ),

Hm. These constants tend to grow - 25 will certainly be too narrow.
But increasing it increases the record size as well.

I think we'll need an embedded __string() type, with a length field
(but still also zero-delimited, for convenience), hm?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/