Re: [patch 0/6] x86, PAT, CPA: Cleanups and minor bug fixes

From: Eric Anholt
Date: Mon Apr 13 2009 - 16:12:13 EST


On Sat, 2009-04-11 at 09:00 +0200, Ingo Molnar wrote:
> * Eric Anholt <eric@xxxxxxxxxx> wrote:
>
> > On Thu, 2009-04-09 at 14:26 -0700, venkatesh.pallipadi@xxxxxxxxx wrote:
> > > This patchset contains cleanups and minor bug fixes in x86 PAT and CPA
> > > related code. The bugs were mostly found by code inspection. There
> > > should not be any functionality changes with this patchset.
> >
> > I've been curious, what are you using to test PAT changes for
> > regressions? I've got some regression tests at:
> >
> > http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/
> >
> > Requires KMS enabled and master of libdrm, but after that you can
> > sudo make check, and it tests execution of several DRM paths
> > without requiring X. In benchmarks/ there are a few
> > microbenchmarks of various mapping types, which has been useful in
> > making sure that we're ending up with the right PTEs.
>
> Looks really nice! Regarding libdrm, is there a version cutoff from
> where it is expected to work just fine? I've got this version:
> libdrm-2.4.6-3.fc11.x86_64.

I should keep the pkgconfig check up to date, but in the worst case it
doesn't compile and you go get new libdrm. The 2.4.6 check right now
appears to be correct.

--
Eric Anholt
eric@xxxxxxxxxx eric.anholt@xxxxxxxxx


Attachment: signature.asc
Description: This is a digitally signed message part