Re: [PATCH 3/3] [BUGFIX] x86/x86_64: fix IRQ migration triggered active device IRQ interrruption

[Yinghai Lu]

On Fri, Apr 10, 2009 at 2:39 PM, Gary Hade <garyhade@xxxxxxxxxx> wrote:

> move_masked_irq() clears the IRQ_MOVE_PENDING desc->status
> bit before calling the function pointed to by
> desc->chip->set_affinity [e.g. set_ioapic_affinity_irq()]
> AND the content of desc->pending_mask is not used after
>  cpumask_and(desc->affinity, desc->pending_mask, cpu_online_mask);
> which precedes the set_affinity function call.  So, I believe
> this provides the necessary separation between the
> IRQ_MOVE_PENDING/desc->pending_mask useage in move_masked_irq()
> and the IRQ_MOVE_PENDING/desc->pending_mask useage in the code
> that the patch adds.
>
that should be ok, they are proteced by spin_lock(&desc->lock)

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/