Re: [PATCH 1/2] ftrace: Separate include/trace/kmemtrace.h tokmemtrace part and tracepoint part

[Ingo Molnar]

* Zhaolei <zhaolei@xxxxxxxxxxxxxx> wrote:

> Current kmemtrace.h is used both as header file of kmemtrace and kmem's
> tracepoints definition.
> Tracepoints' definition file may be used by other code, and should only have
> definition of tracepoint.
> 
> We can separate include/trace/kmemtrace.h into 2 files:
>   include/linux/kmemtrace.h: header file for kmemtrace
>   include/trace/kmem.h:      definition of kmem tracepoints
> 
> Signed-off-by: Zhao Lei <zhaolei@xxxxxxxxxxxxxx>
> ---
>  include/linux/kmemtrace.h             |   25 +++++++++++++++++++++++++
>  include/linux/slab_def.h              |    2 +-
>  include/linux/slub_def.h              |    2 +-
>  include/trace/{kmemtrace.h => kmem.h} |   25 +++----------------------
>  init/main.c                           |    2 +-
>  kernel/trace/kmemtrace.c              |    2 +-
>  kernel/trace/trace.h                  |    2 +-
>  mm/slab.c                             |    2 +-
>  mm/slob.c                             |    2 +-
>  mm/slub.c                             |    2 +-
>  10 files changed, 36 insertions(+), 30 deletions(-)
>  create mode 100644 include/linux/kmemtrace.h
>  rename include/trace/{kmemtrace.h => kmem.h} (78%)

Pekka, Eduard, do you agree with these two patches? Converting those 
tracepoints to TRACE_EVENT() is really nice. The above include file 
restructuring makes sense too - it separates tracepoint definition 
from the plugin init method.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/