Re: [PATCH] rtc: add x86 support for rtc-efi

[Huang Ying]

Hi, Brian,

Sorry for late.

1. Why not put these code into arch/x86/kernel/rtc.c? I think that is
more approriate.

2. It seems that you use both CMOS RTC and EFI RTC. In code path of
read_persistent_clock() and update_persistent_clock(), CMOS RTC is used
for x86_64. I think you should change that too. I have tried to do that
in http://lkml.org/lkml/2007/8/13/602.

Best Regards,
Huang Ying

On Tue, 2009-04-07 at 01:49 +0800, Brian Maly wrote:
> This patch adds support for rtc-efi (RTC Class Driver for EFI-based 
> systems) to x86.
> 
> This patch is based on dann frazier patch [add rtc platform driver for 
> EFI -> http://lkml.org/lkml/2009/1/8/434], and also depends on dann's 
> patch. Dann's patch was in the mm tree, though I think its been merged 
> already.
> 
> This patch has been tested and works perfectly on every x86 EFI system I 
> could find, though all have been EL64 systems. I would appreciate any 
> testing feedback from EL32 systems from anyone that has one and can test.
> 
> Signed-off-by: Brian Maly <bmaly@xxxxxxxxxx>
> 
> 
> 
>

Attachment: signature.asc
Description: This is a digitally signed message part