Re: [PATCH 1/2] MN10300: Move to arch/mn10300/include/asm/

From: Al Viro
Date: Thu Apr 09 2009 - 13:51:17 EST


On Thu, Apr 09, 2009 at 10:30:06AM -0700, Linus Torvalds wrote:
>
>
> On Thu, 9 Apr 2009, David Howells wrote:
> >
> > Move arch headers from include/asm-mn10300/ to arch/mn10300/include/asm/.
>
> This patch looks broken.
>
> It doesn't "move" anything at all. It just copies things, and leaves the
> old files alone.
>
> I wonder if you created the diff by doing
>
> git diff arch/mn10300
>
> because you had other changes pending that you didn't want to include?
>
> Regardless, I'm not applying something this obviously broken.

BTW, *please* use -M when posting that kind of patches. You'll end up with
several lines per moved file and "yes, this is just a move" immediately
obvious from the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/