Re: [PATCH] Tracepoint: Make skb tracepoint use TRACE_EVENT macro

[Steven Rostedt]

On Thu, 9 Apr 2009, Neil Horman wrote:
> 
> I think this seems like a reasonable idea, as long as the sites that register a
> hook for the tracepoint don't need to be updated (and it looks like they dont).
> I do have one nit though: include/trace/skb.h has been emptied and now includes
> include/trace/skb_event_types.h instead.  For the sake of neatness I'd say we
> should either not make that change, and just dump the contents of
> skb_event_types.h into trace/skb.h, or alternatively, remove trace/skb.h
> entirely, and have files that need trace/skb.h include skb_event_types.h
> instead.  Do that and it has my ACK.

Actually that trace/skb.h change is needed. It is not emptied, it still 
has:

 #include <linux/skbuff.h>
 #include <linux/tracepoint.h>

before the include of include/trace/skb_event_types.h

For ftrace to do its magic with the TRACE_EVENT macro, the file that 
contains the TRACE_EVENT can not include tracepoint.h.  ftrace runs the 
skb_event_types.h through a series of redefines of the TRACE_EVENT to 
automate the creation of the directory and files in 
debugfs/tracing/events/*.

We've already changed most of the files in include/trace/ to this format.

I hope we can still have your Ack without making your requested update.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/