Re: [PATCH 36/56] ocfs2: Remove void casts

From: Jack Stone
Date: Thu Apr 09 2009 - 06:17:22 EST


[Added maintainer CCs]
Jack Stone wrote:
> Fixed Patch
>
> Thanks,
>
> Jack
>
> --
>
> ocfs2: Remove void casts
>
> From: Jack Stone <jwjstone@xxxxxxxxxxx>
>
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> ---
>
> fs/ocfs2/dlm/dlmmaster.c | 12 ++++--------
> 1 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
> index f8b653f..52ee37d 100644
> --- a/fs/ocfs2/dlm/dlmmaster.c
> +++ b/fs/ocfs2/dlm/dlmmaster.c
> @@ -758,8 +758,7 @@ lookup:
> spin_unlock(&dlm->spinlock);
> mlog(0, "allocating a new resource\n");
> /* nothing found and we need to allocate one. */
> - alloc_mle = (struct dlm_master_list_entry *)
> - kmem_cache_alloc(dlm_mle_cache, GFP_NOFS);
> + alloc_mle = kmem_cache_alloc(dlm_mle_cache, GFP_NOFS);
> if (!alloc_mle)
> goto leave;
> res = dlm_new_lockres(dlm, lockid, namelen);
> @@ -1543,8 +1542,7 @@ way_up_top:
> spin_unlock(&dlm->master_lock);
> spin_unlock(&dlm->spinlock);
>
> - mle = (struct dlm_master_list_entry *)
> - kmem_cache_alloc(dlm_mle_cache, GFP_NOFS);
> + mle = kmem_cache_alloc(dlm_mle_cache, GFP_NOFS);
> if (!mle) {
> response = DLM_MASTER_RESP_ERROR;
> mlog_errno(-ENOMEM);
> @@ -2455,8 +2453,7 @@ static int dlm_migrate_lockres(struct dlm_ctxt *dlm,
> goto leave;
> }
>
> - mle = (struct dlm_master_list_entry *) kmem_cache_alloc(dlm_mle_cache,
> - GFP_NOFS);
> + mle = kmem_cache_alloc(dlm_mle_cache, GFP_NOFS);
> if (!mle) {
> mlog_errno(ret);
> goto leave;
> @@ -3036,8 +3033,7 @@ int dlm_migrate_request_handler(struct o2net_msg
> *msg, u32 len, void *data,
> hash = dlm_lockid_hash(name, namelen);
>
> /* preallocate.. if this fails, abort */
> - mle = (struct dlm_master_list_entry *) kmem_cache_alloc(dlm_mle_cache,
> - GFP_NOFS);
> + mle = kmem_cache_alloc(dlm_mle_cache, GFP_NOFS);
>
> if (!mle) {
> ret = -ENOMEM;
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/