Re: [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq withouthandler v2

From: Ingo Molnar
Date: Wed Apr 08 2009 - 10:52:51 EST



* Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote:

> Ingo, I think introducing additional dummy here would be a bit
> expencive -- a number of callers of ack_APIC_irq just should not
> check for disable_apic since it's not needed. disable_apic is to
> depend on CONFIG_X86_LOCAL_APIC rather then CONFIG_X86_64
> actually. So make it then. Or you mean something else? Like new
> apic->write_eoi operation? (I'm a bit tired so brain is a half
> functional now :)

no, i meant a dummy apic->write() method in the !apic case. Check
what ack_APIC_irq() does internally.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/