Re: [PATCH 54/56] x86: Remove void casts

[Jack Stone]

Ingo Molnar wrote:
> * Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
>
>   
>> Ingo Molnar wrote:
>>     
>>> * Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
>>>
>>>   
>>>       
>>>> Fixed patch
>>>>
>>>> Thanks,
>>>>     
>>>>         
>>> Hm, what was fixed?
>>>   
>>>       
>> I removed casts on pointer arithmetic which probably still needed to be
>> there to do the arithmetic properly.
>>     
>
> ... which pretty much proves the point that these patches should not 
> go via any "trivial" tree.
>
> Those additions of mmu pointers you did were outright lethal, i 
> doubt this stuff could have booted on both 32-bit and 64-bit x86.
>
> Please dont do this. Or if you do, please double check your change 
> and double check that the relevant vmlinux disassembly is still bit 
> for bit the same.
>   

Thats what I meant by fixed - those changes were removed from the patch.

Thanks,

Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/