Re: [PATCH 08/56] cris: Remove void casts

[Jesper Nilsson]

On Wed, Apr 08, 2009 at 02:34:12PM +0200, Bert Wesarg wrote:
> On Wed, Apr 8, 2009 at 13:21, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
> > Remove uneeded void casts
> >
> > Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> > ---
> >  arch/cris/arch-v32/drivers/cryptocop.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c
> > index 67c61ea..5d20327 100644
> > --- a/arch/cris/arch-v32/drivers/cryptocop.c
> > +++ b/arch/cris/arch-v32/drivers/cryptocop.c
> > @@ -2455,7 +2455,7 @@ static int map_pages_to_iovec(struct iovec *iov, int iovlen, int *iovix, struct
> >                        DEBUG_API(printk("map_page_to_iovec: *pageix=%d >= nopages=%d\n", *pageix, nopages));
> >                        return 0;
> >                }
> > -               iov[*iovix].iov_base = (unsigned char*)page_address(pages[*pageix]) + *pageoffset;
> > +               iov[*iovix].iov_base = page_address(pages[*pageix]) + *pageoffset;
> Pointer arithmetic or intended cast (to avoid warnings for void
> pointer arithmetic).

Good catch. I think I'll drop the patch for now.

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/