Re: [PATCH -tip] x86: do_IRQ - send EOI for x86-32 on irq withouthandler

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> 
> * Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote:
> 
> > For X86-32 if IRQ has no handler it remains non-Ack'ed
> > even if APIC is not requested for being disabled.
> > Fix it.
> 
> nice fix. Did you observe any real hangs in such a situation, or is 
> this via code review?

more stuff needs fixing here first:

arch/x86/kernel/irq.c: In function âdo_IRQâ:
arch/x86/kernel/irq.c:226: error: âdisable_apicâ undeclared (first use in this function)
arch/x86/kernel/irq.c:226: error: (Each undeclared identifier is reported only once
arch/x86/kernel/irq.c:226: error: for each function it appears in.)

like making 'disable_apic' available everywhere.

Or better yet: introduce a dummy apic->write() method in the 
disable_apic=1 case so we can call a straight ack_APIC_irq().

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/