Re: [PATCH 53/56] usb: Remove void casts

[Bert Wesarg]

On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> ---
> Âdrivers/usb/host/ehci-dbg.c | Â Â2 +-
> Âdrivers/usb/host/ehci-mem.c | Â Â6 ++----
> Â2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mem.c b/drivers/usb/host/ehci-mem.c
> index 10d5291..c128491 100644
> --- a/drivers/usb/host/ehci-mem.c
> +++ b/drivers/usb/host/ehci-mem.c
> @@ -212,8 +211,7 @@ static int ehci_mem_init (struct ehci_hcd *ehci, gfp_t flags)
> Â Â Â Â}
>
> Â Â Â Â/* Hardware periodic table */
> - Â Â Â ehci->periodic = (__le32 *)
> - Â Â Â Â Â Â Â dma_alloc_coherent (ehci_to_hcd(ehci)->self.controller,
> + Â Â Â ehci->periodic = dma_alloc_coherent (ehci_to_hcd(ehci)->self.controller,
Hmm, I would leave this in, because of the big endian/little endian
annotation. Else sparse (the static semantic checker) could complain.


> Â Â Â Â Â Â Â Â Â Â Â Âehci->periodic_size * sizeof(__le32),
> Â Â Â Â Â Â Â Â Â Â Â Â&ehci->periodic_dma, 0);
> Â Â Â Âif (ehci->periodic == NULL) {

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/