Re: [PATCH 22/56] message/fusion: Remove void casts

[Bert Wesarg]

On Wed, Apr 8, 2009 at 13:21, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> ---
> Âdrivers/message/fusion/mptbase.c | Â Â6 +++---
> Âdrivers/message/fusion/mptctl.c Â| Â Â4 ++--
> Âdrivers/message/fusion/mptfc.c  |  Â4 ++--
> Â3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
> index c638171..fbcd791 100644
> --- a/drivers/message/fusion/mptctl.c
> +++ b/drivers/message/fusion/mptctl.c
> @@ -2667,7 +2667,7 @@ mptctl_hp_targetinfo(unsigned long arg)
> Â Â Â Â Â Â Â Â/* Issue the second config page request */
> Â Â Â Â Â Â Â Âcfg.action = MPI_CONFIG_ACTION_PAGE_READ_CURRENT;
> Â Â Â Â Â Â Â Âdata_sz = (int) cfg.cfghdr.hdr->PageLength * 4;
> - Â Â Â Â Â Â Â pg3_alloc = (SCSIDevicePage3_t *) pci_alloc_consistent(
> + Â Â Â Â Â Â Â pg3_alloc = pci_alloc_consistent(
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âioc->pcidev, data_sz, &page_dma);
Dito. (Sorry for being lazy in typing from this point up).

> Â Â Â Â Â Â Â Âif (pg3_alloc) {
> Â Â Â Â Â Â Â Â Â Â Â Âcfg.physAddr = page_dma;
> diff --git a/drivers/message/fusion/mptfc.c b/drivers/message/fusion/mptfc.c
> index c3c24fd..d22acfd 100644
> --- a/drivers/message/fusion/mptfc.c
> +++ b/drivers/message/fusion/mptfc.c
> @@ -766,7 +766,7 @@ mptfc_GetFcPortPage0(MPT_ADAPTER *ioc, int portnum)
>
> Â Â Â Âdata_sz = hdr.PageLength * 4;
> Â Â Â Ârc = -ENOMEM;
> - Â Â Â ppage0_alloc = (FCPortPage0_t *) pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);
> + Â Â Â ppage0_alloc = pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);
> Â Â Â Âif (ppage0_alloc) {
>
> Âtry_again:
> @@ -907,7 +907,7 @@ start_over:
> Â Â Â Â Â Â Â Âif (data_sz < sizeof(FCPortPage1_t))
> Â Â Â Â Â Â Â Â Â Â Â Âdata_sz = sizeof(FCPortPage1_t);
>
> - Â Â Â Â Â Â Â page1_alloc = (FCPortPage1_t *) pci_alloc_consistent(ioc->pcidev,
> + Â Â Â Â Â Â Â page1_alloc = pci_alloc_consistent(ioc->pcidev,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âdata_sz,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â&page1_dma);
Please check.

> Â Â Â Â Â Â Â Âif (!page1_alloc)

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/