Re: [PATCH -V2 09/13] fsnotify: add correlations between events

[Andrew Morton]

On Fri, 27 Mar 2009 16:05:54 -0400
Eric Paris <eparis@xxxxxxxxxx> wrote:

> inotify sends userspace a correlation between events when they are related
> (aka when dentries are moved).  This adds that same support for all
> fsnotify events.
> 

So is this a new userspace-visible feature?

>
> ...
>
> +static atomic_t fsnotify_sync_cookie = ATOMIC_INIT(0);
> +
> +u32 fsnotify_get_cookie(void)
> +{
> +	return atomic_inc_return(&fsnotify_sync_cookie);
> +}
> +EXPORT_SYMBOL_GPL(fsnotify_get_cookie);

Please make a poilcy of documenting the global symbols.  Especially the
exported-to-modules symbols.  At least.

>
> ...
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/