Re: [Patch 2/3] Prevent false sgi-xpc heartbeat failures.

[Andrew Morton]

On Fri, 03 Apr 2009 11:04:42 -0500
holt@xxxxxxx wrote:

> +void (*xpc_allow_hb) (short partid);
> +void (*xpc_disallow_hb) (short partid);
> +void (*xpc_disallow_all_hbs) (void);
>  void (*xpc_heartbeat_init) (void);
>  void (*xpc_heartbeat_exit) (void);
>  void (*xpc_increment_heartbeat) (void);

The driver adds a huge number of globals.

As a pointless cleanup it might be nice to convert all this:

: int (*xpc_setup_partitions_sn) (void);
: void (*xpc_teardown_partitions_sn) (void);
: enum xp_retval (*xpc_get_partition_rsvd_page_pa) (void *buf, u64 *cookie,
: 						  unsigned long *rp_pa,
: 						  size_t *len);
: int (*xpc_setup_rsvd_page_sn) (struct xpc_rsvd_page *rp);
: 
: void (*xpc_allow_hb) (short partid);
: void (*xpc_disallow_hb) (short partid);
: void (*xpc_disallow_all_hbs) (void);
: void (*xpc_heartbeat_init) (void);
: void (*xpc_heartbeat_exit) (void);
: void (*xpc_increment_heartbeat) (void);
: void (*xpc_offline_heartbeat) (void);
: void (*xpc_online_heartbeat) (void);
: enum xp_retval (*xpc_get_remote_heartbeat) (struct xpc_partition *part);
: 
: enum xp_retval (*xpc_make_first_contact) (struct xpc_partition *part);
: void (*xpc_notify_senders_of_disconnect) (struct xpc_channel *ch);
: u64 (*xpc_get_chctl_all_flags) (struct xpc_partition *part);
: enum xp_retval (*xpc_setup_msg_structures) (struct xpc_channel *ch);
: void (*xpc_teardown_msg_structures) (struct xpc_channel *ch);
: void (*xpc_process_msg_chctl_flags) (struct xpc_partition *part, int ch_number);
: int (*xpc_n_of_deliverable_payloads) (struct xpc_channel *ch);
: void *(*xpc_get_deliverable_payload) (struct xpc_channel *ch);
: 
: void (*xpc_request_partition_activation) (struct xpc_rsvd_page *remote_rp,
: 					  unsigned long remote_rp_pa,
: 					  int nasid);
: void (*xpc_request_partition_reactivation) (struct xpc_partition *part);
: void (*xpc_request_partition_deactivation) (struct xpc_partition *part);
: void (*xpc_cancel_partition_deactivation_request) (struct xpc_partition *part);
: 
: void (*xpc_process_activate_IRQ_rcvd) (void);
: enum xp_retval (*xpc_setup_ch_structures_sn) (struct xpc_partition *part);
: void (*xpc_teardown_ch_structures_sn) (struct xpc_partition *part);
: 
: void (*xpc_indicate_partition_engaged) (struct xpc_partition *part);
: int (*xpc_partition_engaged) (short partid);
: int (*xpc_any_partition_engaged) (void);
: void (*xpc_indicate_partition_disengaged) (struct xpc_partition *part);
: void (*xpc_assume_partition_disengaged) (short partid);
: 
: void (*xpc_send_chctl_closerequest) (struct xpc_channel *ch,
: 				     unsigned long *irq_flags);
: void (*xpc_send_chctl_closereply) (struct xpc_channel *ch,
: 				   unsigned long *irq_flags);
: void (*xpc_send_chctl_openrequest) (struct xpc_channel *ch,
: 				    unsigned long *irq_flags);
: void (*xpc_send_chctl_openreply) (struct xpc_channel *ch,
: 				  unsigned long *irq_flags);
: 
: enum xp_retval (*xpc_save_remote_msgqueue_pa) (struct xpc_channel *ch,
: 					       unsigned long msgqueue_pa);
: 
: enum xp_retval (*xpc_send_payload) (struct xpc_channel *ch, u32 flags,
: 				    void *payload, u16 payload_size,
: 				    u8 notify_type, xpc_notify_func func,
: 				    void *key);
: void (*xpc_received_payload) (struct xpc_channel *ch, void *payload);

into

struct xpc_operations {
	int (*setup_partitions_sn)(void);
	...
	void (*xpc_received_payload)(struct xpc_channel *ch, void *payload);
} xpc_operations;

Or not ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/