Re: [GIT *] intel-iommu updates for 2.6.30 (second batch)

From: Ingo Molnar
Date: Tue Apr 07 2009 - 01:49:39 EST



* David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:

> On Tue, 2009-04-07 at 07:37 +0200, Ingo Molnar wrote:
> > I suspect these bits are the ones that broke the upstream build:
> >
> > drivers/pci/dmar.c:47: error: expected â=â, â,â, â;â, âasmâ or
> > â__attribute__â before âdmar_tbl_sizeâ
> > drivers/pci/dmar.c:62: warning: âstruct acpi_dmar_device_scopeâ
> > declared inside parameter list
> > drivers/pci/dmar.c:62: warning: its scope is only this definition or
> > declaration, which is probably not what you want
>
> Yeah, <acpi/acpi.h> was being included implicitly for me, but
> certain configs don't do that. Alexander Beregalov sent a patch
> for that, which I added to my tree before Linus pulled it.
>
> Commit 46f06b72378d3187f0d12f7a60d020676bfbf332 is the fix.

No, that does not fix it - it's still broken with
v2.6.29-9854-gd508afb. Try the config i sent.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/