Re: [PATCH] Update old Mini-HOWTO for ftrace

[Minchan Kim]

One more thing.

Please, Not attach your patch but inline one.
Many people want to add their comments to line-by-line.

Tip -
If you use gmail with web, your patch is mangled by web server.
That will hurt maintainers.

Documentation/email-clients.txt can help you. :)

On Tue, Apr 7, 2009 at 8:32 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> GeunSik,
>
> On Tue, 7 Apr 2009, GeunSik Lim wrote:
>
>> Sorry,
>> I mistake because I don't understand how to submit patch exactly.
>
> To submit a patch you need to have:
>
> 1) useful subject line
>
> Â [PATCH] subsystem: what does the patch do
>
> Â subsystem in your care is: ftrace
>
> 2) useful patch description
>
> Â explains what the patch does. Which bug/problem it fixes or which
> Â enhancement it provides
>
> Â Look at the git log. Each commit has an (more or lesss) usefull
> Â description, but you get the idea. If you see a confusing or
> Â cryptic description you need way more time to figure out what the
> Â patch does or what it is supposed to do.
>
> 3) Your Signed-off-by
>
> Â Signed-off-by is the certificate of origin as described in
>
> Â Documentation/SubmittingPatches
>
> Â You can only add your own Signed-off-by. You never can add the
> Â Signed-off-by of some one else.
>
>> I just appended below "singned-off" contents for convenience.
>> Sorry again.
>>
>> Â ÂSigned-off-by: GeunSik Lim <leemgs1@xxxxxxxxx>
>> Â ÂSigned-off-by: Steven Rostedt <srostedt@xxxxxxxxxx>
>> Â ÂSigned-off-by: Ingo Molnar <mingo@xxxxxxx>
>
> That's how it might look later on. It would say:
>
>    GeunSik Lim    wrote the patch
>    Steven Rostedt  Âpicked it up from your mail and sent it to Ingo
>    Ingo Molnar    received it from Steven's mail and applied it
>
> There is no way for you to forsee how your patch will be picked up and
> propagated. It might go via Andrew Morton or directly to Linus. Ok ?
>
> So you only add your own Signed-off-by.
>
> Hope that helps. Thanks,
>
> Â Â tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



-- 
Kinds regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/