Re: [PATCH 003/003] USB: serial: sierra driver bug fixes inopen/close and callbacks

[Greg KH]

On Mon, Apr 06, 2009 at 05:06:02PM -0700, Elina wrote:
> Subject: [PATCH 003/003] USB:  serial: sierra driver bug fixes in 
> open/close and callbacks
> From: Elina Pasheva <epasheva@xxxxxxxxxxxxxxxxxx>
> 
> ïThe series of 3 patches modify sierra usb serial driver with
> blacklisting of specific non-serial interfaces, bug fixing and
> performance improvements. 
> This is [PATCH 003/003]. This patch depends on [PATCH 002/003].
> The following is summary of changes we have made to sierra.c driver in
> [PATCH 003/003] dealing with bug fixes in open/close and callbacks:
> - Fixed a problem in sierra_send_setup() for composite modems. Should
> not be sending ACM commands to interfaces that are OBEX. Doing this
> causes an apparent failure as the ACM command has to time out before the
> interface can start being used
> ï- Fixed a problem in function sierra_indat_callback() which would stop
> receiving traffic from a modem if a number of URB failures occur. Failed
> URBs are not resubmitted for the next read and there is only a limited
> number of URBs allocated for the IN path. After this number of failures,
> the receive path stops working on a particular interface.
> - Moved allocation of memory-based items to Open function from the
> Startup function to conserve memory. This way, only interfaces that are
> active will allocate and use the memory instead of all the memory being
> allocated up front whether it would be needed or not

Again, please split this up into logical pieces.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/