Re: [PATCH] Update old Mini-HOWTO for ftrace

From: Thomas Gleixner
Date: Mon Apr 06 2009 - 19:32:46 EST


GeunSik,

On Tue, 7 Apr 2009, GeunSik Lim wrote:

> Sorry,
> I mistake because I don't understand how to submit patch exactly.

To submit a patch you need to have:

1) useful subject line

[PATCH] subsystem: what does the patch do

subsystem in your care is: ftrace

2) useful patch description

explains what the patch does. Which bug/problem it fixes or which
enhancement it provides

Look at the git log. Each commit has an (more or lesss) usefull
description, but you get the idea. If you see a confusing or
cryptic description you need way more time to figure out what the
patch does or what it is supposed to do.

3) Your Signed-off-by

Signed-off-by is the certificate of origin as described in

Documentation/SubmittingPatches

You can only add your own Signed-off-by. You never can add the
Signed-off-by of some one else.

> I just appended below "singned-off" contents for convenience.
> Sorry again.
>
> Signed-off-by: GeunSik Lim <leemgs1@xxxxxxxxx>
> Signed-off-by: Steven Rostedt <srostedt@xxxxxxxxxx>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

That's how it might look later on. It would say:

GeunSik Lim wrote the patch
Steven Rostedt picked it up from your mail and sent it to Ingo
Ingo Molnar received it from Steven's mail and applied it

There is no way for you to forsee how your patch will be picked up and
propagated. It might go via Andrew Morton or directly to Linus. Ok ?

So you only add your own Signed-off-by.

Hope that helps. Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/