Re: bug in drivers/edac/edac_core.h pci_write_bits32()

[Andrew Morton]

(cc maintainer)

On Thu, 26 Mar 2009 16:54:01 -0700 "Jeff Haran" <jharan@xxxxxxxxxxx> wrote:

> 2.6.29 and previous versions seem to contain this bug which I found just
> eyeballing the code:
> 
> static inline void pci_write_bits32(struct pci_dev *pdev, int offset,
>                     u32 value, u32 mask)
> {
>     if (mask != 0xffff) {
>         u32 buf;
> 
>         pci_read_config_dword(pdev, offset, &buf);
>         value &= mask;
>         buf &= ~mask;
>         value |= buf;
>     }
> 
>     pci_write_config_dword(pdev, offset, value);
> }
> 
> I'm pretty sure that "if" statement should be:
> 
> 	if (mask != 0xffffffff) {
> 
> Please copy my email address in any response as I do not subscribe.
> 
> Thanks,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/