Re: Staging: sxg: Add support to download the firmware usingrequest_firmware()

[David Woodhouse]

On Sun, 2009-04-05 at 19:19 +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/linus/cda3b517a478324233d9be71232b60e2e2efe848
> Commit:     cda3b517a478324233d9be71232b60e2e2efe848
> Parent:     e5ea8da06ba610551a75c79c1467aae379e953ce
> Author:     Mithlesh Thukral <mithlesh@xxxxxxxxxxxxxx>
> AuthorDate: Fri Mar 20 17:39:04 2009 +0530
> Committer:  Greg Kroah-Hartman <gregkh@xxxxxxx>
> CommitDate: Fri Apr 3 14:53:14 2009 -0700
> 
>     Staging: sxg: Add support to download the firmware using request_firmware()
>     
>     Add support for downloading the firmware using kernel-builtin mechanism.
>     This will remove the need for the firmware files in the driver source code.
>     
>     Signed-off-by: Christopher Harrer <charrer@xxxxxxxxxxxxxx>
>     Signed-off-by: Mithlesh Thukral <mithlesh@xxxxxxxxxxxxxx>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> ---
>  drivers/staging/sxg/saharadbgdownload-1.71.c  | 5233 ------------------------
>  drivers/staging/sxg/saharadbgdownloadB-1.10.c | 5251 -------------------------
>  drivers/staging/sxg/saharadownload-1.55.c     | 4531 ---------------------
>  drivers/staging/sxg/saharadownloadB-1.8.c     | 4532 ---------------------
>  drivers/staging/sxg/sxg.c                     |  206 +-
>  firmware/Makefile                             |    2 +
>  firmware/WHENCE                               |   12 +
>  firmware/sxg/saharadbgdownloadB.sys.ihex      | 3937 ++++++++++++++++++
>  firmware/sxg/saharadownloadB.sys.ihex         | 3385 ++++++++++++++++
>  9 files changed, 7437 insertions(+), 19652 deletions(-)

NO!

What the hell are you playing at, Greg?

We don't want to be adding _new_ binary firmware into the firmware/
directory -- that was only the temporary location for removing the
_existing_ crap.

We have the linux-firmware.git repository, into which we are collecting
new firmware blobs. Don't add them to the kernel sources.

This whole 'staging' clusterfuck is getting out of hand.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/