Re: [PATCH] don't raise all privs on setuid-root file with fE set(v2)

From: Serge E. Hallyn
Date: Sat Apr 04 2009 - 23:56:30 EST


> Serge E. Hallyn wrote:
> > Distributions face a backward compatibility problem with starting to use
> > file capabilities. For instance, removing setuid root from ping and
> > doing setcap cap_net_raw=pe means that booting with an older kernel
> > or one compiled without file capabilities means ping won't work for
> > non-root users.
> >
> > In order to replace the setuid root bit on a capability-unaware
> > program, one has to set the effective, or legacy, file capability,
> > which makes the capability effective immediately. This patch
> > uses the legacy bit as a queue to not automatically add full
>
> s/queue/cue/

Oops.

(I wonder whether this is worth resending?)

> > privilege to a setuid-root program.
> >
> > So, with this patch, an ordinary setuid-root program will run with
> > privilege. But if /bin/ping has both setuid-root and cap_net_raw in
> > fP and fE, then ping (when run by non-root user) will not run
> > with only cap_net_raw.
>
> Acked-by: Andrew G. Morgan <morgan@xxxxxxxxxx>

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/