Re: [PATCH 1/1] Tell linkwatch about new interfaces

From: David Miller
Date: Sat Apr 04 2009 - 20:06:10 EST


From: Andrew Lutomirski <amluto@xxxxxxxxx>
Date: Wed, 1 Apr 2009 11:40:06 -0400

> When a network driver registers a new interface, linkwatch will not notice,
> and hence not set the rfc2863 operstate, until netif_carrier_on gets called.
> If the new interface has no carrier when it is connected, then a status of
> "unknown" is reported to userspace, which confuses various tools
> (NetworkManager, for example).
>
> This fires a linkwatch event for all new interfaces, so that operstate
> gets set reasonably quickly.
>
> Signed-off-by: Andrew Lutomirski <amluto@xxxxxxxxx>

The default assumed state for a freshly registered network
device is that the link is up.

If that disagrees from reality, the driver should make the
appropriate netif_carrier_off() call.

I'm sure you'll find that the e1000 driver is not doing this
and that is what causes the bug you are seeing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/