Re: [PATCH 1/2] SMI Detector: a simple module for detecting System Management Interrupts

[Jon Masters]

Thanks Clark and Frederic. I am currently on a train going through the  
Rockies but will send an update tomorrow. Sorry for top posting.

Jon.



On Apr 2, 2009, at 14:16, Clark Williams <williams@xxxxxxxxxx> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Thu, 2 Apr 2009 21:05:26 +0200
> FrÃdÃric Weisbecker <fweisbec@xxxxxxxxx> wrote:
>
>
> > > +#if 1
> > > +       val = simple_strtol(buffer, NULL, 10);
> > > +#else
> > > +       if (strict_strtol(buffer, 10, &val))
> > > +               return -EINVAL;
> > > +#endif
> >
> >
> >
> > So I guess the #else statement can disappear? :-)
>
> Ugh, don't blame Jon for that. I was trying to get rid of some
> checkpatch warnings and was experimenting with strict vs. simple
> strtol.
>
> I'll clean that up in the next iteration. Or Jon can and will then
> abuse me :)
>
> Clark
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.9 (GNU/Linux)
>
> iEYEARECAAYFAknVHRoACgkQHyuj/+TTEp0ndwCfe4ZeEsdflVY3udv9ukk7wKVQ
> OycAn1Nl1OQr7nPUxPp3rln5SYVE4Bcn
> =kZRN
> -----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/