Re: [PATCH] x86: make mtrr code could use debugpat

From: Jaswinder Singh Rajput
Date: Sat Apr 04 2009 - 02:54:10 EST


On Sat, 2009-04-04 at 03:18 +0200, Ingo Molnar wrote:
> * Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > On Fri, 3 Apr 2009, Yinghai Lu wrote:
> > >
> > > only print out get_mtrr when debugpat
> >
> > Is that get_mtrr message really so interesting that it needs to be
> > printed out at all? Even with debugpat?
>
> With debugpat it's probably interesting - i think only a very small
> fraction of users will enable it, and if they do we really want to
> track all MTRR state.
>
> Since old MTRR state gets destroyed by new settings we better have a
> clear idea how the BIOS set it, that might give us clues about
> quirks, etc.
>
> Based on MTRR bugreport patterns i was the one who asked Yinghai
> during the development cycle to add more debugging there - so i'm to
> blame for those printouts. We had several cases where it would have
> been useful had we known the precise history of MTRR settings.
>
> I was under the impression that KERN_DEBUG would only show up on the
> console if 'debug' is passed in on the boot command line - but your
> bootlog didnt have 'debug' in it and i guess having it so frequently
> in the dmesg is confusing as well. It might even be there for every
> Xorg startup.
>

If you still want to debug it, use some special parameters at command
line to avoid annoyance to others.

These debug messages really screwed up my life from last month.

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/