Re: 2.6.29 git, resume from ram broken on thinkpad

From: Ingo Molnar
Date: Fri Apr 03 2009 - 13:35:27 EST



* Arkadiusz Miskiewicz <a.miskiewicz@xxxxxxxxx> wrote:

> On Friday 03 of April 2009, Chris Wright wrote:
> > * Arkadiusz Miskiewicz (a.miskiewicz@xxxxxxxxx) wrote:
> > > What about 9ea09af3bd3090e8349ca2899ca2011bd94cda85 ?
> > >
> > > stop_machine: introduce stop_machine_create/destroy.
> >
> > That is later fixed in a0e280e0f33f6c859a235fb69a875ed8f3420388.
> >
> > Can you please verify if 2.6.29 works for you?
>
> I think that the guilty part is
> CONFIG_CC_STACKPROTECTOR_ALL=y
> CONFIG_CC_STACKPROTECTOR=y

aha!!

> Disabling stackprotector makes problem go away (and my build of
> final 2.6.29 had it disabled while later builds got it enabled at
> some moment).

Thanks a ton for that info. Could you try:

http://people.redhat.com/mingo/tip.git/README

with stack-protector re-enabled please? This fix:

1f23b77: x86: disable stack-protector for __restore_processor_state()

might do the trick!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/