Re: [PATCH] x86: disable stack-protector for__restore_processor_state()

From: Ingo Molnar
Date: Fri Apr 03 2009 - 13:31:21 EST



* Joseph Cihula <joseph.cihula@xxxxxxxxx> wrote:

> The __restore_processor_state() fn restores %gs on resume from S3.
> As such, it cannot be protected by the stack-protector guard since
> %gs will not be correct on function entry.
>
> There are only a few other fns in this file and it should not
> negatively impact kernel security that they will also have the
> stack-protector guard removed (and so it's not worth moving them
> to another file).
>
> Without this change, S3 resume on a kernel built with
> CONFIG_CC_STACKPROTECTOR_ALL=y will fail.
>
> Signed-off-by: Joseph Cihula <joseph.cihula@xxxxxxxxx>

ah ... very nice!

applied to tip:x86/urgent, thanks Joseph!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/