Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop

From: David Howells
Date: Fri Apr 03 2009 - 09:57:55 EST


Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> > + if (!aops->bmap)
> > goto check_error;
>
> What are you doing using bmap? You really shouldn't call into it from
> anywhere but FIBMAP. Yes, swap currently does but it's a major pain
> in the neck and Peter has been working on a proper interface for swap
> for a while.

Checking to see whether there's a hole in the file. If there's a hole, that
represents data I need to fetch; if there isn't that represents data I have in
the cache. I don't care _where_ the data is, only whether it exists or not.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/