Re: [PATCH] acpi: simplify module_param namespace

From: Len Brown
Date: Thu Apr 02 2009 - 22:45:33 EST


On Thu, 2 Apr 2009, Sam Ravnborg wrote:

> > +
> > +processor-objs += processor_core.o processor_throttling.o \
> > + processor_idle.o processor_thermal.o
> > +ifdef CONFIG_CPU_FREQ
> > +processor-objs += processor_perflib.o
> > +endif
>
> It would be nicer to do:
> processor-y := processor_core.o processor_throttling.o
> processor-y += processor_idle.o processor_thermal.o
> processor-$(CONFIG_CPU_FREQ) += processor_perflib.o
>
> Assuming processor-objs was not assinged before in this file.
>
> Sam

Can-do.
In Rusty's defense, these lines were in his patch simply because he moved
them.

thanks,
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/