Re: [PATCH] ide: falconide/q40ide - Use __ide_mm_{in,out}sw() for data transfer

From: Bartlomiej Zolnierkiewicz
Date: Thu Apr 02 2009 - 15:37:42 EST


On Wednesday 01 April 2009, Geert Uytterhoeven wrote:
> Both of commits f94116aeec7a299640dd692128e1d22178affa8d ("ide: cleanup
> <asm-m68k/ide.h>") and 15a453a955f89f6545118770c669b52e925368bd ("ide: include
> <asm/ide.h> only when needed") break falconide:
>
> | Uniform Multi-Platform E-IDE driver
> | ide: Falcon IDE controller
> | Probing IDE interface ide0...
> | hda: Sarge m68k, ATA DISK drive
> | ide0 at 0xfff00000 on irq 15 (serialized)
> | ide-gd driver 1.18
> | hda: max request size: 128KiB
> | hda: 2118816 sectors (1084 MB) w/256KiB Cache, CHS=2102/16/63
> | hda:<4>hda: lost interrupt
>
> This happens because falconide relies on {in,out}sw() being redefined in
> <asm/ide.h>, as included by <linux/ide.h>, which is no longer the case.
> Use __ide_mm_{in,out}sw() from <asm/ide.h> instead, just like
> ide_{in,out}put_data() do.
>
> The same problem seems to exist in q40ide.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

applied

Many thanks for fixing this issue and the IRQF_SHARED one!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/