Re: [PATCH 22/43] CacheFiles: Add a hook to write a single page ofdata to an inode [ver #46]

[Rik van Riel]

David Howells wrote:
> Add an address space operation to write one single page of data to an inode at
> a page-aligned location (thus permitting the implementation to be highly
> optimised).  The data source is a single page.
>   
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index b43b955..5d17070 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -817,6 +817,8 @@ const struct address_space_operations ext2_nobh_aops = {
>  	.direct_IO		= ext2_direct_IO,
>  	.writepages		= ext2_writepages,
>  	.migratepage		= buffer_migrate_page,
> +	.write_one_page		= generic_file_buffered_write_one_page,
> +	.write_one_page		= generic_file_buffered_write_one_page
Adding the same function pointer twice seems a bit excessive.

Other than that, the patch looks good :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/