Re: [PATCH 10/17] bio: use bio_create_from_sgl() in bio_map_user_iov()

From: Tejun Heo
Date: Wed Apr 01 2009 - 18:19:53 EST


Boaz Harrosh wrote:
>> ret = get_user_pages_fast(uaddr, local_nr_pages, rw == READ,
>> - &pages[cur_page]);
>> + &pages[nents]);
>
> Fast look at all users of get_user_pages_fast().
>
> This can be converted to take an sglist instead of pages* array.
> Outside of this code all users either have a fixed-size allocated array
> or hard coded one page. This here is the main user. (Out of 5)

Yeah, that would be nice, although it's understandable that gup taking
page array as parameter.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/