Inverted NUMA test in setup_pcpu_remap()?

From: David Miller
Date: Wed Apr 01 2009 - 01:31:50 EST



The test currently is:

if (!cpu_has_pse || pcpu_need_numa())
return -EINVAL;

Don't we really mean "!pcpu_need_numa()"?

The way I read the intent, setup_pcpu_remap() should be used in the
NUMA case. But that's not what's happening because of how this test
is coded.

In fact, the test here is identical to the one used in
setup_pcpu_embed()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/