Re: [PATCH 07/12] DRBD: main

[Alexey Dobriyan]

On Mon, Mar 23, 2009 at 04:48:02PM +0100, Philipp Reisner wrote:
> +#if CONFIG_PROC_FS
> +	/*
> +	 * register with procfs
> +	 */
> +	drbd_proc = create_proc_entry("drbd",  S_IFREG | S_IRUGO , NULL);
> +
> +	if (!drbd_proc)	{
> +		printk(KERN_ERR "drbd: unable to register proc file\n");
> +		goto Enomem;
> +	}
> +
> +	drbd_proc->proc_fops = &drbd_proc_fops;

Use proc_create().

> +	drbd_proc->owner = THIS_MODULE;

Unnecessary now.

> +#else
> +# error "Currently drbd depends on the proc file system (CONFIG_PROC_FS)"
> +#endif

You should "depends on PROC_FS" then and remove this #error.
#ifdef would also become unnecessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/