[tip:x86/cleanups] x86: Fix a couple of sparse warnings in arch/x86/kernel/apic/io_apic.c

From: Dmitri Vorobiev
Date: Sun Mar 22 2009 - 15:41:08 EST


Commit-ID: 1cc185211a9cb913f6adbe3354e5c256f456ebd2
Gitweb: http://git.kernel.org/tip/1cc185211a9cb913f6adbe3354e5c256f456ebd2
Author: Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx>
AuthorDate: Sun, 22 Mar 2009 19:11:09 +0200
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Sun, 22 Mar 2009 18:15:14 +0100

x86: Fix a couple of sparse warnings in arch/x86/kernel/apic/io_apic.c

Impact: cleanup

This patch fixes the following sparse warnings:

arch/x86/kernel/apic/io_apic.c:3602:17: warning: symbol 'hpet_msi_type'
was not declared. Should it be static?

arch/x86/kernel/apic/io_apic.c:3467:30: warning: Using plain integer as
NULL pointer

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx>
LKML-Reference: <1237741871-5827-2-git-send-email-dmitri.vorobiev@xxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>


---
arch/x86/kernel/apic/io_apic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 42cdc78..ea97e5e 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3464,7 +3464,7 @@ int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
int ret, sub_handle;
struct msi_desc *msidesc;
unsigned int irq_want;
- struct intel_iommu *iommu = 0;
+ struct intel_iommu *iommu = NULL;
int index = 0;

irq_want = nr_irqs_gsi;
@@ -3599,7 +3599,7 @@ static void hpet_msi_set_affinity(unsigned int irq, const struct cpumask *mask)

#endif /* CONFIG_SMP */

-struct irq_chip hpet_msi_type = {
+static struct irq_chip hpet_msi_type = {
.name = "HPET_MSI",
.unmask = hpet_msi_unmask,
.mask = hpet_msi_mask,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/