[PATCH -tip] x86: cpu/cpu.h cleanup

From: Jaswinder Singh Rajput
Date: Sun Mar 22 2009 - 04:17:10 EST


Hello Ingo,

Is it worth to move arch/x86/kernel/cpu/cpu.h data to asm/cpu.h and if
required we can also make it private like:
#ifdef __KERNEL__
#ifndef MODULE
private data for kernel only
#endif
#endif

By this way we move header files to include directory. Or you have some
better option.

From: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
Date: Sun, 22 Mar 2009 13:28:39 +0530
Subject: [PATCH] x86: cpu/cpu.h cleanup

Impact: cleanup

- Fix various style issues

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
---
arch/x86/kernel/cpu/cpu.h | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/x86/kernel/cpu/cpu.h b/arch/x86/kernel/cpu/cpu.h
index 9469ecb..6de9a90 100644
--- a/arch/x86/kernel/cpu/cpu.h
+++ b/arch/x86/kernel/cpu/cpu.h
@@ -3,25 +3,25 @@
#define ARCH_X86_CPU_H

struct cpu_model_info {
- int vendor;
- int family;
- const char *model_names[16];
+ int vendor;
+ int family;
+ const char *model_names[16];
};

/* attempt to consolidate cpu attributes */
struct cpu_dev {
- const char * c_vendor;
+ const char *c_vendor;

/* some have two possibilities for cpuid string */
- const char * c_ident[2];
+ const char *c_ident[2];

struct cpu_model_info c_models[4];

- void (*c_early_init)(struct cpuinfo_x86 *c);
- void (*c_init)(struct cpuinfo_x86 * c);
- void (*c_identify)(struct cpuinfo_x86 * c);
- unsigned int (*c_size_cache)(struct cpuinfo_x86 * c, unsigned int size);
- int c_x86_vendor;
+ void (*c_early_init)(struct cpuinfo_x86 *);
+ void (*c_init)(struct cpuinfo_x86 *);
+ void (*c_identify)(struct cpuinfo_x86 *);
+ unsigned int (*c_size_cache)(struct cpuinfo_x86 *, unsigned int);
+ int c_x86_vendor;
};

#define cpu_dev_register(cpu_devX) \
--
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/