Re: [PATCH 5/7] blktrace: report EBUSY correctly

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Fri, Mar 20, 2009 at 09:49:08AM +0800, Li Zefan escreveu:
> > blk_trace_remove_queue() returns EINVAL if q->blk_trace == NULL,
> > but blk_trace_setup_queue() doesn't return EBUSY if q->blk_trace != NULL.
> > 
> >  # echo 0 > sdaX/trace/enable
> >  # echo 0 > sdaX/trace/enable
> >  bash: echo: write error: Invalid argument
> >  # echo 1 > sdaX/trace/enable
> >  # echo 1 > sdaX/trace/enable
> >  (should return EBUSY)
> > 
> > Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
> 
> Thanks for all the testing, its being really appreciated,
> 
> Acked-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

thanks Arnaldo - i've added your acks to tip:tracing/blktrace.

Jens, are the changes fine with you too, can i merge them into 
tracing/core, for v2.6.30?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/