Re: [PATCH 06/13] async_tx: add support for asynchronous GF multiplication

[H. Peter Anvin]

Ilya Yanok wrote:
> > >
> > That doesn't explain what you expect the code to do.  It still doesn't
> > make sense to me.
>
> We defined async_pq() function as hardware can do GF multiplication of
> arbitrary elements and we want to take advantage of this fact. But by
> the design of ASYNC_TX API we have to provide synchronous version of
> that function too.

I don't think that makes sense since the algorithm doesn't use 
vector-vector multiplications and there is no need for them.  As such, 
you're actively excluding support for hardware which only provides 
scalar-vector multiplication, even though that is all we need.

In fact, vectorizing the constant doesn't make much sense.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/