Re: [PATCH v4 06/12] PCI: Introduce pci_rescan_bus()

[Andrew Morton]

On Wed, 18 Mar 2009 16:39:56 -0600 Alex Chiang <achiang@xxxxxx> wrote:

> This API is used by the PCI core to rescan a bus and rediscover
> newly added devices.
> 
> Over time, it is expected that the various PCI hotplug drivers
> will migrate to this interface and away from the old
> pci_do_scan_bus() interface.
> 
> ...
>
> @@ -1195,10 +1195,39 @@ struct pci_bus * __devinit pci_scan_bus_parented(struct device *parent,
>  EXPORT_SYMBOL(pci_scan_bus_parented);
>  
>  #ifdef CONFIG_HOTPLUG
> +/**
> + * pci_rescan_bus - scan a PCI bus for devices.
> + * @bus: PCI bus to scan
> + *
> + * Scan a PCI bus and child buses for new devices, adds them,
> + * and enables them.
> + *
> + * Returns the max number of subordinate bus discovered.
> + */
> +unsigned int __devinit pci_rescan_bus(struct pci_bus *bus)
> +{
> +	unsigned int max;
> +	struct pci_dev *dev;
> +
> +	max = pci_scan_child_bus(bus);
> +	list_for_each_entry(dev, &bus->devices, bus_list)
> +		if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
> +		    dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)
> +			if (dev->subordinate)
> +				pci_bus_size_bridges(dev->subordinate);
> +
> +	pci_bus_assign_resources(bus);
> +	pci_enable_bridges(bus);
> +	pci_bus_add_devices(bus);
> +
> +	return max;
> +}
> +
>  EXPORT_SYMBOL(pci_add_new_bus);
>  EXPORT_SYMBOL(pci_scan_slot);
>  EXPORT_SYMBOL(pci_scan_bridge);
>  EXPORT_SYMBOL_GPL(pci_scan_child_bus);
> +EXPORT_SYMBOL_GPL(pci_rescan_bus);

uhm, is there any rationale for the seemingly-random mixup of export types
in this interface?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/