Re: [PATCH 1/3] Restrict definition of a variable inkernel/sysctl.c

From: Ingo Molnar
Date: Thu Mar 19 2009 - 03:25:37 EST



* Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx> wrote:

> The variable "one" in kernel/sysctl.c is used only if either CONFIG_HIGHMEM,
> or CONFIG_DETECT_SOFTLOCKUP are defined (or both). Hence, if neither option
> is enabled, the following error is produced:
>
> CC kernel/sysctl.o
> kernel/sysctl.c:99: warning: 'one' defined but not used
>
> This patch fixes the warning by moving the variable definition under an
> appropriate preprocessor construct.
>
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx>
> ---
> kernel/sysctl.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)

Note, this warning is already fixed in the tip:core/softlockup tree
and queued up for v2.6.30.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/