Re: [PATCH] ipu_idmac: code clean-up and robustness improvements

From: Dan Williams
Date: Mon Mar 16 2009 - 17:59:44 EST


On Fri, Mar 13, 2009 at 12:41 AM, Guennadi Liakhovetski <lg@xxxxxxx> wrote:
> General code clean-up: remove superfluous semicolons, update comments.
> Robustness improvements: add DMA error handling to the ISR, move common code
> fragments to functions, fix scatter-gather element queuing in the ISR, survive
> channel freeing and re-allocation in a quick succession.
>
> Signed-off-by: Guennadi Liakhovetski <lg@xxxxxxx>
> ---
>
> Dan, I've been using this patch for a while, without any need for a
> change, so, it should be fine to go upstream.
>

Are you sure that we will never want to bisect in between these
several topics? I would feel more comfortable with at least the fixes
separated from the code refactoring/pure additions.

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/