Re: [PATCH 29/35] Do not store the PCP high and batch watermarks inthe per-cpu structure

[Christoph Lameter]

On Mon, 16 Mar 2009, Mel Gorman wrote:

> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -166,8 +166,6 @@ static inline int is_unevictable_lru(enum lru_list l)
>
>  struct per_cpu_pages {
>  	int count;		/* number of pages in the list */
> -	int high;		/* high watermark, emptying needed */
> -	int batch;		/* chunk size for buddy add/remove */


There is a hole here on 64 bit systems.

>
>  	/* Lists of pages, one per migrate type stored on the pcp-lists */
>  	struct list_head lists[MIGRATE_PCPTYPES];
> @@ -285,6 +283,12 @@ struct zone {
>  		unsigned long pages_mark[3];
>  	};
>
> +	/* high watermark for per-cpu lists, emptying needed */
> +	u16 pcp_high;
> +
> +	/* chunk size for buddy add/remove to per-cpu lists*/
> +	u16 pcp_batch;
> +

Move this up to fill the hole?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/