Re: [PATCH] rcu_barrier VS cpu_hotplug: Ensure callbacks in deadcpu are migrated to online cpu

[Lai Jiangshan]

Paul E. McKenney wrote:
> On Sat, Mar 07, 2009 at 06:54:38PM +0800, Lai Jiangshan wrote:
>> [RFC]
>> I don't like this patch, but I thought for some days and I can't
>> thought out a better one.
>>
>> I'm very hope rcu_barrier() can be called anywhere(any sleepable context).
>> But get_online_cpus() is a very large lock, it limits rcu_barrier().
>>
>> We can avoid get_online_cpus() easily for rcupreempt by using a new rcu_barrier:
>> void rcu_barrier(void)
>> {
>> 	for each rcu_data {
>> 		lock rcu_data;
>> 		if rcu_data is not empty, queue a callback for rcu_barrier;
>> 		unlock rcu_data;
>> 	}
>> }
>> But we cannot use this algorithm for rcuclassic and rcutree,
>> rcu_data in rcuclassic and rcutree have not a spinlock for queuing callback.
>>
>> From: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
>>
>> cpu hotplug may be happened asynchronously, some rcu callbacks are maybe
>> still in dead cpu, rcu_barrier() also needs to wait for these rcu callbacks
>> to complete, so we must ensure callbacks in dead cpu are migrated to
>> online cpu.
> 
> Hmmm...  I thought that on_each_cpu() took care of interlocking with
> CPU hotplug via smp_call_function().  During a CPU-hotplug operation,
> the RCU callbacks do get migrated from the CPU going offline.  Are you
> seeing a sequence of events that finds a hole in this approach?
> 
> Now, if a CPU were to go offline in the middle of smp_call_function()
> there could be trouble, but I was under the impression that the
> preempt_disable() in on_each_cpu() prevented this from happening.
> 
> So, please tell me more!
> 

preempt_disable() ensure online cpu is still online until preempt_enable(),
but preempt_disable()/preempt_enable() can't ensure rcu callbacks migrated.


rcu_barrier()			|	_cpu_down()
				|		__cpu_die() (cpu D is dead)
	........................|............................
	on_each_cpu()		|
	........................|...........................
	wait_for_completion()	|		rcu_offline_cpu() (move cpu D's
				|			rcu callbacks to A,B,or C)


on_each_cpu() does not queue rcu_barrier_callback to cpu D(it's dead).
So rcu_barrier() will not wait for callbacks which are original at cpu D.

We need ensure callbacks in dead cpu are migrated to online cpu before
we call on_each_cpu().

Thanks, Lai.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/