Re: [PATCH] x86: introduce bootmem_state

From: Jeremy Fitzhardinge
Date: Fri Mar 06 2009 - 17:12:21 EST


H. Peter Anvin wrote:
Yinghai Lu wrote:
Impact: cleanup

extend after_bootmem and after_init_bootmem to bootmem_state
and will have BEFORE_BOOTMEM, DURING_BOOTMEM, AFTER_BOOTMEM


Wouldn't it make more sense to add these as system_state enumerations
and use relational comparisons on them (< <= >= >)?

Please, no. system_state should be deprecated; its hard enough to have a notion of some kind of system-wide state, but putting subsystem specific substates into it just makes things worse.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/