Re: [PATCH 4/5 v3] tracing/core: drop the old ftrace_printkimplementation in favour of ftrace_bprintk

From: Ingo Molnar
Date: Fri Mar 06 2009 - 13:49:33 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

>
> On Fri, 6 Mar 2009, Ingo Molnar wrote:
> > >
> > > i've put them into a separate branch forked off
> > > tip:tracing/ftrace: tip:tracing/printk. The two vsprintf
> > > patches are in tip:core/printk and merged into tracing/ftrace.
> > >
> > > You can thus apply your current enhancements without any
> > > interaction with me - and merge tracing/printk into the
> > > tip:tracing/ftrace branch on your own schedule, ok?
> >
> > ah - i misunderstood - i see that it interacts with your commits
> > from last night.
> >
> > I've excluded tip:tracing/printk from tip:master for now and
> > will let you guys fix it up when you have time for it.
>
> Ingo,
>
> It compiles fine. Only a new item in the struct was added, nothing was
> removed. It just prints out a bit funny ;-)
>
> You can go ahead and merge it into tracing/ftrace, and then I
> can work with that to fix up the formatting.

triggers this build failure on certain configs:

kernel/trace/trace.c:1205: error: implicit declaration of function 'vbin_printf'
kernel/trace/trace_output.c:64: error: implicit declaration of function 'bstr_printf'

so i've excluded it from tip:master again for now.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/