Re: [PATCH 5/6] kvm/x86: call kvm_lapic_sync_from_vapic withpreemption disabled

[Marcelo Tosatti]

On Thu, Mar 05, 2009 at 01:12:32PM +0100, Joerg Roedel wrote:
> The function uses kmap_atomic. Calling it with preemption enabled is
> racy.

kmap_atomic disables preemption?

void *kmap_atomic_prot(struct page *page, enum km_type type, pgprot_t prot)
{                       
        enum fixed_addresses idx;
        unsigned long vaddr;    
                        
        /* even !CONFIG_PREEMPT needs this, for in_atomic in  * do_page_fault */
        pagefault_disable();


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/