Re: [PATCH 0/3] xfs: fix sparse warnings

From: Felix Blyakher
Date: Thu Mar 05 2009 - 12:43:35 EST



On Mar 4, 2009, at 12:33 PM, Hannes Eder wrote:

The following series fixes a fair amount of the remaining sparse
warnings in fs/xfs with !CONFIG_XFS_DEBUG.

With CONFIG_XFS_DEBUG we still got alot of "Should it be static?"
warnings, but that's a different issue.

Looks good to me with the changes Christoph pointed out.
I'll push it in. Thanks.

Reviewed-by: Felix Blyakher <felixb@xxxxxxx>



---
Hannes Eder (3):
xfs: include header files for prototypes
xfs: make symbols static
xfs: move declaration to header file

fs/xfs/linux-2.6/xfs_ioctl.c | 1 +
fs/xfs/linux-2.6/xfs_super.c | 6 +++---
fs/xfs/support/debug.c | 1 +
fs/xfs/xfs_bmap.c | 2 +-
fs/xfs/xfs_da_btree.h | 1 +
fs/xfs/xfs_dir2.c | 2 --
fs/xfs/xfs_dir2_leaf.c | 2 +-
7 files changed, 8 insertions(+), 7 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/